search

realiotech / realio-network

Realio Network is an EVM compatible blockchain built using the Cosmos SDK and Tendermint consensus engine. It is focused on the issuance and management of digitally native and real-world assets across many chains.
MIT License
39 stars 15 forks source link

Feat: Upgrade SDK 47 and upstream x/evm and x/feemarket module from evmos #144

Open GNaD13 opened 4 months ago

GNaD13 commented 4 months ago

Close #143

GNaD13 commented 4 months ago

left a few comments. Can you also make sure the lint job is passing?

Yeah, this PR is still on a draft. We will do all the linting after done with the code

jiujiteiro commented 4 months ago

In addition to the comments left in the code, Im curious why we have added all of those files in the tests directory. It looks like they were copied over from the now archived ethermint repo.

GNaD13 commented 4 months ago

In addition to the comments left in the code, Im curious why we have added all of those files in the tests directory. It looks like they were copied over from the now archived ethermint repo.

yeah, so we just import some testing helpers file from ethermin for realio-network testing. I've removed the unused file

jiujiteiro commented 4 months ago

@GNaD13 the ethermint repo is not maintained/archived as far as i know. If we think we need to import anything from there lets review please. Ideally Id like to import nothing from it, strictly import from evmos directly. You can see some of the testing deps are out of date for example truffle is no longer maintained. All testing tools we should aim to use hardhat on the evm side.

GNaD13 commented 4 months ago

@GNaD13 the ethermint repo is not maintained/archived as far as i know. If we think we need to import anything from there lets review please. Ideally Id like to import nothing from it, strictly import from evmos directly. You can see some of the testing deps are out of date for example truffle is no longer maintained. All testing tools we should aim to use hardhat on the evm side.

Yeah, I changed to used code from evmos repository

jiujiteiro commented 4 months ago

@GNaD13 @neitdung once we change the upgrade from v3 to v2, can we add "v2" to the module path in the go.mod?

that way, all the imports will have /realiotech/realio-network/v2.....

this is a pattern to follow on every upgrade for versioning.

GNaD13 commented 4 months ago

@GNaD13 @neitdung once we change the upgrade from v3 to v2, can we add "v2" to the module path in the go.mod?

that way, all the imports will have /realiotech/realio-network/v2.....

this is a pattern to follow on every upgrade for versioning.

yeah, we got it

GNaD13 commented 3 months ago

Some issue with ante handler, we need to waiting for this PR