Make it (sort of) secure

reality / dbot

IRC bot of the 21st century.

Other

62 stars 35 forks source link

Make it (sort of) secure #667

Closed skokkk closed 6 years ago

skokkk commented 6 years ago

Although it's not a lot more secure, hell, it just makes it look secure - so do it and don't look back!

somehibs commented 6 years ago

This extra computation does not offer any security. Base64 is just an encoding, which in this case reduces performance for no benefit. This commit message is lacking information for a later developer. What are you securing? What actions does a user have to take to fix their install?

I veto despite not being a reviewer.

skokkk commented 6 years ago

touché @somehibs