realitycollective / com.realitytoolkit.core

The all-purpose framework for building the next reality
https://realitytoolkit.realitycollective.net/
MIT License
3 stars 0 forks source link

Do not force CanvasUtility down peoples throats #48

Closed FejZa closed 1 year ago

FejZa commented 1 year ago

Reality Collective - Reality Toolkit Pull Request

Overview

The CanvasUtility keeps messing up prefabs and scenes in my projects all the time, because we are literally showeling it down people's throats on every occassion. I end up with prefabs where multiple CanvasUtilities are on the object and keep unknowingly saving those prefab changes while editing them.

There is only one thing to do with that utility, which is making sure to prompt the user to add it when a World Space canvas is selected. If yes, then we add it. If not, the user is aware it's needed and will add it when needed. We need to stop messing with people's projects without them being aware of it.

SimonDarksideJ commented 1 year ago

Query @FejZa , so what is the path now for developers using Unity UI with the canvas Utility? since it is required or UI to work with the input providers? Warn them to add it manually, or raise a log when it's not found?

FejZa commented 1 year ago

The path is the same. You add the component either manually where you need it or you press "OK" when prompted to add it to world space canvases. The only difference here is that it won't add anything unless the user specifically tells it to do so.

SimonDarksideJ commented 1 year ago

Great stuff, we must endeavour to include that in the docs @FejZa :D