Closed wdauchy closed 4 years ago
seems like tests are failing because of nginx; I don't think it is related to my changes
@realityforge or @cyberflow - any chance to review this?
Unfortunately atm I am on a deathmarch and then off to holiday so wont be able to take a look :(
@wdauchy I'm not sure, but what happened if es_host will be 0.0.0.0? Because for kibana 3 it's configure nginx/apache and if i understand correctly config.js in kibana3 configuring browser part. It's working for you?
@cyberflow good point. I was just expecting node['kibana']['elasticsearch']['hosts'] would be set to correct values but indeed the default is 127.0.0.1 which makes it non working as well as 0.0.0.0.
What do you think if I test node['kibana']['elasticsearch']['hosts'].first value?
e.g
if ['127.0.0.1', '0.0.0.0'].include? node['kibana']['elasticsearch']['hosts'].first
elasticsearch: "http://" + window.location.hostname + ":<%= @es_port %>",
else
elasticsearch: "http://<%= @es_host %>:<%= @es_port %>",
end
@wdauchy I think that it's not make sense do it with only '.first' element of array. If you want to do this will be better make config with all addresses of elasticsearch cluster. Also i prefer to do special attribute for windows.location.hostname
option in kibana 3 config. I think it's will be more flexible.
@cyberflow I also agree .first is not ideal but that's precisely what is used in kibana4.rb:
./recipes/kibana4.rb: es_host: node['kibana']['elasticsearch']['hosts'].first,
Closing due to lack of activity and out of date
use the same system to templatise the ES url for both kibana3 and kibana4