realityking / mp4v2

Automatically exported from code.google.com/p/mp4v2
Other
0 stars 0 forks source link

Error in Types.cpp #59

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Look at Types.cpp ImageHeader line 292 
2.
3.

What is the expected output? What do you see instead? the "Magic Numbers" 
are reversed in the BT_BMP 

What version of the product are you using? On what operating system?
it's still in the latest trunk ! 

Please provide any additional information below.

 static ImageHeader IMAGE_HEADERS[] = {
        { BT_BMP,  "\x4d\x42" },  MB   should be "\x42\x4d" BM 
        { BT_GIF,  "GIF87a" },
        { BT_GIF,  "GIF89a" },
        { BT_JPEG, "\xff\xd8\xff\xe0" },
        { BT_PNG,  "\x89\x50\x4e\x47\x0d\x0a\x1a\x0a" },
        { BT_UNDEFINED } // must be last
    };

Original issue reported on code.google.com by wils...@tampabay.rr.com on 24 Mar 2010 at 7:04

GoogleCodeExporter commented 9 years ago
That should be type.cpp sorry ! 

Original comment by wils...@tampabay.rr.com on 24 Mar 2010 at 7:06

GoogleCodeExporter commented 9 years ago
I think this is correct:

http://en.wikipedia.org/wiki/BMP_file_format#BMP_File_Header

This should be fixed in 374; let me know.

Original comment by kid...@gmail.com on 2 Apr 2010 at 1:14