Clicking "Show new article of the day" notification crashes app.

reallyreadit / web

The Readup web app, embed, extension, and native client readers.

GNU Affero General Public License v3.0

2 stars 0 forks source link

Clicking "Show new article of the day" notification crashes app. #54

Closed jacamera closed 2 years ago

jacamera commented 2 years ago

Minor annoyance. See attached screen recording.

https://user-images.githubusercontent.com/18013188/171032464-4b94c852-2a7f-4f9d-af03-65552f0737cf.mp4

th0rgall commented 2 years ago

Yep, it is still this issue: https://www.pivotaltracker.com/story/show/180707933

The annoying thing is that it's hard to debug. You need to somehow simulate the situation where the AOTD crosses over at midnight (PST?), but then do it at any given time to figure out what is going on. How would you approach that @jacamera?

jacamera commented 2 years ago

I believe this should be fixed here: https://github.com/reallyreadit/web/commit/9e3e7a5b8fb2e153b7b80d75e400b1849d6f47e7

To debug I just temporarily set newAotd to true in the constructor to show the banner and then debugged the handler. I'll close this tomorrow after confirming that it works in production without any additional issues.