realm / SwiftCov

A tool to generate test code coverage information for Swift.
MIT License
562 stars 41 forks source link

Check if .swift files are directories #42

Closed stephencelis closed 9 years ago

stephencelis commented 9 years ago

A convention I've used and seen used elsewhere it to name the repo $(TARGET_NAME).swift, which is thus cloned as the directory, too (e.g. Dollar.swift, Few.swift, SQLite.swift).

I discovered from reading the source that -- $SOURCE_DIR works, but figure it would be a good bug to fix. I'd dig in deeper now but couldn't get the tests to run and need to run to work :stuck_out_tongue:

jpsim commented 9 years ago

Definitely a good idea!

jpsim commented 9 years ago

Could probably be done quite easily in coverage.py: https://github.com/realm/SwiftCov/blob/0.1.0/Source/SwiftCovFramework/coverage.py#L172-L176