realm / SwiftLint

A tool to enforce Swift style and conventions.
https://realm.github.io/SwiftLint
MIT License
18.61k stars 2.22k forks source link

Prohibit configuration key inference #5513

Closed SimplyDanny closed 6 months ago

SimplyDanny commented 6 months ago

While this is already implemented, it only works when a configuration is updated by calling apply(configuration:) on it somewhere. This imperceptible detail could lead to confusing. So better prohibit the use of the feature for the time being as long as a good solution is found. So far, no explicit configuration keys have been removed.

SwiftLintBot commented 6 months ago
1 Warning
:warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
:book: Linting Aerial with this PR took 1.93s vs 1.24s on main (55% slower)
:book: Linting Alamofire with this PR took 1.81s vs 1.8s on main (0% slower)
:book: Linting Brave with this PR took 10.4s vs 10.43s on main (0% faster)
:book: Linting DuckDuckGo with this PR took 5.6s vs 5.58s on main (0% slower)
:book: Linting Firefox with this PR took 12.92s vs 12.98s on main (0% faster)
:book: Linting Kickstarter with this PR took 12.57s vs 12.59s on main (0% faster)
:book: Linting Moya with this PR took 0.71s vs 0.7s on main (1% slower)
:book: Linting NetNewsWire with this PR took 3.7s vs 3.72s on main (0% faster)
:book: Linting Nimble with this PR took 1.02s vs 1.02s on main (0% slower)
:book: Linting PocketCasts with this PR took 10.23s vs 10.17s on main (0% slower)
:book: Linting Quick with this PR took 0.46s vs 0.46s on main (0% slower)
:book: Linting Realm with this PR took 6.34s vs 6.35s on main (0% faster)
:book: Linting Sourcery with this PR took 3.15s vs 3.14s on main (0% slower)
:book: Linting Swift with this PR took 6.22s vs 6.24s on main (0% faster)
:book: Linting VLC with this PR took 1.69s vs 1.69s on main (0% slower)
:book: Linting Wire with this PR took 23.59s vs 23.49s on main (0% slower)
:book: Linting WordPress with this PR took 15.32s vs 15.3s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Prohibit configuration key inference.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by :no_entry_sign: Danger