search

realm / SwiftLint

A tool to enforce Swift style and conventions.
https://realm.github.io/SwiftLint
MIT License
18.61k stars 2.22k forks source link

#5461 added ib_segue_action case in TypeContent #5524

Open dk-talks opened 6 months ago

dk-talks commented 6 months ago

Hey! I have added a new case to TypeContent enum for ib_segue_action. And also adapted the change in TypeContentsOrderRule.swift.

SwiftLintBot commented 6 months ago
9 Warnings
:warning: If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
:warning: This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:568:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
:warning: This PR introduced a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:595:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
:warning: This PR introduced a violation in DuckDuckGo: /DuckDuckGo/RootDebugViewController.swift:79:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'other_method' (type_contents_order)
:warning: This PR introduced a violation in DuckDuckGo: /DuckDuckGo/RootDebugViewController.swift:88:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'other_method' (type_contents_order)
:warning: This PR introduced a violation in DuckDuckGo: /DuckDuckGo/RootDebugViewController.swift:98:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'other_method' (type_contents_order)
:warning: This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:770:5: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
:warning: This PR introduced a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:776:13: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
:warning: This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/People/PeopleViewController.swift:188:20: warning: Type Contents Order Violation: An 'ib_segue_action' should not be placed amongst the type content(s) 'type_method' (type_contents_order)
22 Messages
:book: Linting Aerial with this PR took 1.12s vs 1.13s on main (0% faster)
:book: Linting Alamofire with this PR took 1.64s vs 1.65s on main (0% faster)
:book: Linting Brave with this PR took 9.33s vs 9.48s on main (1% faster)
:book: Linting DuckDuckGo with this PR took 4.99s vs 5.11s on main (2% faster)
:book: Linting Firefox with this PR took 11.85s vs 11.9s on main (0% faster)
:book: Linting Kickstarter with this PR took 11.44s vs 11.48s on main (0% faster)
:book: Linting Moya with this PR took 0.63s vs 0.63s on main (0% slower)
:book: Linting NetNewsWire with this PR took 3.51s vs 3.52s on main (0% faster)
:book: Linting Nimble with this PR took 0.93s vs 0.93s on main (0% slower)
:book: Linting PocketCasts with this PR took 9.27s vs 9.19s on main (0% slower)
:book: Linting Quick with this PR took 0.42s vs 0.42s on main (0% slower)
:book: Linting Realm with this PR took 5.78s vs 5.73s on main (0% slower)
:book: Linting Sourcery with this PR took 2.88s vs 2.87s on main (0% slower)
:book: Linting Swift with this PR took 5.65s vs 5.72s on main (1% faster)
:book: Linting VLC with this PR took 1.52s vs 1.52s on main (0% slower)
:book: Linting Wire with this PR took 20.99s vs 21.08s on main (0% faster)
:book: Linting WordPress with this PR took 13.77s vs 13.8s on main (0% faster)
:book: This PR fixed a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:568:20: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
:book: This PR fixed a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:595:20: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
:book: This PR fixed a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:770:5: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
:book: This PR fixed a violation in DuckDuckGo: /DuckDuckGo/TabViewController.swift:776:13: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
:book: This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/People/PeopleViewController.swift:188:20: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'type_method' (type_contents_order)

Here's an example of your CHANGELOG entry:

* #5461 added ib_segue_action case in TypeContent.  
  [dk-talks](https://github.com/dk-talks)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by :no_entry_sign: Danger

dk-talks commented 5 months ago

Hi, @SimplyDanny still the build is not passing, is there something else needed to be done?

SimplyDanny commented 5 months ago

Hi, @SimplyDanny still the build is not passing, is there something else needed to be done?

Now that you have removed the entry from the default list, the test reference update needs to be reverted.

dk-talks commented 5 months ago

Hey @SimplyDanny. Now that the build has passed, is there anything else needs to be done or is it enough to merge and close the issue?

SimplyDanny commented 5 months ago

Hey @SimplyDanny. Now that the build has passed, is there anything else needs to be done or is it enough to merge and close the issue?

  1. This change needs tests. See TypeContentsOrderRuleTests.
  2. A changelog entry needs to be added. See CHANGELOG.md.