SwiftLintBot
commented
5 months ago | 1 Warning | |
|---|---|
| :warning: | If this is a user-facing change, please include a CHANGELOG entry to credit yourself! You can find it at CHANGELOG.md. |
| 17 Messages | |
|---|---|
| :book: | Linting Aerial with this PR took 0.89s vs 0.89s on main (0% slower) |
| :book: | Linting Alamofire with this PR took 1.27s vs 1.24s on main (2% slower) |
| :book: | Linting Brave with this PR took 7.29s vs 7.29s on main (0% slower) |
| :book: | Linting DuckDuckGo with this PR took 4.09s vs 4.08s on main (0% slower) |
| :book: | Linting Firefox with this PR took 10.46s vs 10.58s on main (1% faster) |
| :book: | Linting Kickstarter with this PR took 9.2s vs 9.11s on main (0% slower) |
| :book: | Linting Moya with this PR took 0.51s vs 0.51s on main (0% slower) |
| :book: | Linting NetNewsWire with this PR took 2.47s vs 2.52s on main (1% faster) |
| :book: | Linting Nimble with this PR took 0.73s vs 0.76s on main (3% faster) |
| :book: | Linting PocketCasts with this PR took 7.93s vs 7.99s on main (0% faster) |
| :book: | Linting Quick with this PR took 0.41s vs 0.42s on main (2% faster) |
| :book: | Linting Realm with this PR took 4.6s vs 4.6s on main (0% slower) |
| :book: | Linting Sourcery with this PR took 2.32s vs 2.3s on main (0% slower) |
| :book: | Linting Swift with this PR took 4.42s vs 4.44s on main (0% faster) |
| :book: | Linting VLC with this PR took 1.22s vs 1.22s on main (0% slower) |
| :book: | Linting Wire with this PR took 17.19s vs 17.26s on main (0% faster) |
| :book: | Linting WordPress with this PR took 12.86s vs 12.85s on main (0% slower) |
Here's an example of your CHANGELOG entry:
* Fix superfluous disable command for custom rules.
[mildm8nnered](https://github.com/mildm8nnered)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text.
Generated by :no_entry_sign: Danger
Very much a work in progress, so please ignore for now.
This is redo of #4755 (which was reverted in #5336).
I took the original changes from #4755 and worked from there. The changes I've made on top of the original PR can be seen at https://github.com/mildm8nnered/SwiftLint/compare/mildm8nnered-marcelos-changes-back...mildm8nnered:SwiftLint:mildm8nnered-fix-superfluous-disable-command-for-custom-rules
I thought this was good, but
custom_rulesnow seems to be picking up issues that it didn't see before (fatalError), and there were some issues with superfluous triggering in some tests that I was not expecting either, so I think more work is required here.