search

realm / SwiftLint

A tool to enforce Swift style and conventions.
https://realm.github.io/SwiftLint
MIT License
18.46k stars 2.2k forks source link

[New rule] Add new rule for functions parameters #5569

Closed kimdv closed 1 month ago

kimdv commented 1 month ago

Fixes: https://github.com/realm/SwiftLint/issues/5564

This rule will ensure that all parameters are on a newline. This will enhance the diff when doing reviews.

Not sure if we also should expand this rule for arrays and dictionaries. But I think it would be best to split those rules into multiple.

SwiftLintBot commented 1 month ago
30183 Warnings
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:119:33: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:365:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:365:70: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:378:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:389:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:407:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:407:89: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:423:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:487:112: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:487:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:487:87: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:491:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:491:85: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:491:97: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:526:46: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:526:83: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:565:43: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:142:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:228:59: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/GeoCoding.swift:83:59: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:172:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:265:59: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:137:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:223:59: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:107:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:107:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:107:76: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:118:39: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:118:53: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:118:77: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:135:42: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:165:41: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:175:33: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:175:41: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:227:36: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:255:34: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:286:39: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:97:43: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:97:57: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/AerialVideo.swift:17:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:47:50: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:51:50: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:51:75: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:111:33: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:16:22: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:16:36: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:169:50: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/Thumbnails.swift:196:55: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:231:51: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:258:37: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:13:48: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:146:62: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:16:44: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:201:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:232:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:274:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:281:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoDownload.swift:45:30: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:13:50: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:14:50: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:14:75: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:30:20: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:30:67: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:78:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoLoader.swift:94:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:127:37: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:151:30: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:186:48: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:203:56: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:203:76: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:44:39: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/VideoManager.swift:95:39: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:132:46: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:132:59: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:132:87: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:132:99: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:149:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:29:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:69:23: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:69:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:84:38: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:104:31: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:104:41: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:124:44: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:124:82: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:163:44: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:163:66: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:42:36: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:90:44: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/DownloadManager.swift:90:66: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Downloads/FileHelpers.swift:25:37: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:101:29: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/ErrorLog.swift:23:29: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Extensions/DispatchQueue+Extension.swift:13:49: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Extensions/DispatchQueue+Extension.swift:13:82: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:22:33: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:22:45: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:22:58: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:22:83: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:22:97: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:454:52: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/HardwareDetection.swift:131:57: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/HardwareDetection.swift:131:78: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/HardwareDetection.swift:131:95: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/HardwareDetection.swift:35:54: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager+Goodies.swift:17:40: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager+Goodies.swift:17:70: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager+Goodies.swift:29:40: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager+Goodies.swift:29:70: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager+Goodies.swift:45:37: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/ISSoundAdditions/SoundOutputManager+Goodies.swift:45:59: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Locations.swift:114:56: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Locations.swift:132:56: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Locations.swift:89:56: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:151:47: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:731:41: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:801:44: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/ManifestLoader.swift:898:36: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/PlaybackSpeed.swift:20:39: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:424:46: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:449:47: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:474:47: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:499:45: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:524:50: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:590:23: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Prefs/PrefsInfo.swift:690:23: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Sidebar.swift:58:41: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/Source.swift:276:47: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceInfo.swift:301:43: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:234:51: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:383:45: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: This PR introduced a violation in Aerial: /Aerial/Source/Models/Sources/SourceList.swift:439:71: warning: Function parameters newline Violation: Function parameters should be on a new line (function_parameters_newline)
:warning: Danger found 30183 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 132.
17 Messages
:book: Linting Aerial with this PR took 1.26s vs 1.25s on main (0% slower)
:book: Linting Alamofire with this PR took 1.83s vs 1.8s on main (1% slower)
:book: Linting Brave with this PR took 10.52s vs 10.51s on main (0% slower)
:book: Linting DuckDuckGo with this PR took 5.51s vs 5.47s on main (0% slower)
:book: Linting Firefox with this PR took 13.66s vs 13.54s on main (0% slower)
:book: Linting Kickstarter with this PR took 12.82s vs 12.69s on main (1% slower)
:book: Linting Moya with this PR took 0.7s vs 0.71s on main (1% faster)
:book: Linting NetNewsWire with this PR took 3.77s vs 3.74s on main (0% slower)
:book: Linting Nimble with this PR took 1.03s vs 1.05s on main (1% faster)
:book: Linting PocketCasts with this PR took 10.37s vs 10.29s on main (0% slower)
:book: Linting Quick with this PR took 0.46s vs 0.48s on main (4% faster)
:book: Linting Realm with this PR took 6.42s vs 6.36s on main (0% slower)
:book: Linting Sourcery with this PR took 3.21s vs 3.22s on main (0% faster)
:book: Linting Swift with this PR took 6.41s vs 6.33s on main (1% slower)
:book: Linting VLC with this PR took 1.69s vs 1.68s on main (0% slower)
:book: Linting Wire with this PR took 23.84s vs 23.71s on main (0% slower)
:book: Linting WordPress with this PR took 15.93s vs 15.78s on main (0% slower)

Generated by :no_entry_sign: Danger

mildm8nnered commented 1 month ago

I think this might be covered already by existing multiline_xxxx rules.

multiline_arguments: Multiline Arguments multiline_arguments_brackets: Multiline Arguments Brackets multiline_function_chains: Multiline Function Chains multiline_literal_brackets: Multiline Literal Brackets multiline_parameters: Multiline Parameters multiline_parameters_brackets: Multiline Parameters Brackets

I think that multiline_parameters with allows_single_line set to false, and either multiline_arguments_brackets or multiline_parameters_brackets (they appear to do much the same thing) will be almost equivalent to this rule.

multiline_literal_brackets will do the same for arrays.

Rules about multiline parameters etc probably do belong in the multiline_xxxx namespace, but it is getting a bit crowded.

kimdv commented 1 month ago

I think this might be covered already by existing multiline_xxxx rules.

multiline_arguments: Multiline Arguments multiline_arguments_brackets: Multiline Arguments Brackets multiline_function_chains: Multiline Function Chains multiline_literal_brackets: Multiline Literal Brackets multiline_parameters: Multiline Parameters multiline_parameters_brackets: Multiline Parameters Brackets

I think that multiline_parameters with allows_single_line set to false, and either multiline_arguments_brackets or multiline_parameters_brackets (they appear to do much the same thing) will be almost equivalent to this rule.

multiline_literal_brackets will do the same for arrays.

Rules about multiline parameters etc probably do belong in the multiline_xxxx namespace, but it is getting a bit crowded.

Oh! Thanks!

I might look into those.

kimdv commented 1 month ago

@mildm8nnered is it right that it's not possible to require all items inside an array etc to be on newline? I see that multiline_literal_brackets have a "allow_single_line" like multiline_parameters

mildm8nnered commented 1 month ago

@mildm8nnered is it right that it's not possible to require all items inside an array etc to be on newline? I see that multiline_literal_brackets have a "allow_single_line" like multiline_parameters

So I'm not sure whether it's "right" or not - I suspect that the multiline_xxxx rules grew over time, and that there's not as much consistency as there could be between their various options.

It's quite likely that they be consolidated and rationalized a bit, but that's hard to do without potentially breaking existing deployments.

kimdv commented 1 month ago

@mildm8nnered is it right that it's not possible to require all items inside an array etc to be on newline? I see that multiline_literal_brackets have a "allow_single_line" like multiline_parameters

So I'm not sure whether it's "right" or not - I suspect that the multiline_xxxx rules grew over time, and that there's not as much consistency as there could be between their various options.

It's quite likely that they be consolidated and rationalized a bit, but that's hard to do without potentially breaking existing deployments.

If they should be consolidated, we could keep them as is, and then reintroduce a new rule hat is more consistent :)

mildm8nnered commented 1 month ago

If they should be consolidated, we could keep them as is, and then reintroduce a new rule hat is more consistent :)

So that would be a possible way forward, but given that they have pretty good coverage across them already, would that be a good use of time?

I think if there's something that you can't do with some combination of the existing rules, new options would be the path of least resistance maybe.

SimplyDanny commented 1 month ago

Let me add my two cents: I don't have a complete overview on all the multiline_* rules, so don't know what would have to be touched. But if we can make them more consistent and align their configuration options (making them more understandable for users and for contributors), go for it. Changed behavior should be documented in the CHANGELOG so that people get informed. Other than that, rules being in use already should not be blocking. Of course, discussing alternative options is always valid as well.