realm / SwiftLint

A tool to enforce Swift style and conventions.
https://realm.github.io/SwiftLint
MIT License
18.46k stars 2.2k forks source link

Treat conditional code as if it was always active #5581

Closed SimplyDanny closed 1 month ago

SimplyDanny commented 1 month ago

Fixes #5574.

SwiftLintBot commented 1 month ago
1 Warning
:warning: This PR may need tests.
17 Messages
:book: Linting Aerial with this PR took 0.79s vs 0.8s on main (1% faster)
:book: Linting Alamofire with this PR took 1.13s vs 1.14s on main (0% faster)
:book: Linting Brave with this PR took 6.65s vs 6.61s on main (0% slower)
:book: Linting DuckDuckGo with this PR took 3.54s vs 3.51s on main (0% slower)
:book: Linting Firefox with this PR took 9.46s vs 9.47s on main (0% faster)
:book: Linting Kickstarter with this PR took 8.35s vs 8.12s on main (2% slower)
:book: Linting Moya with this PR took 0.48s vs 0.48s on main (0% slower)
:book: Linting NetNewsWire with this PR took 2.34s vs 2.4s on main (2% faster)
:book: Linting Nimble with this PR took 0.66s vs 0.67s on main (1% faster)
:book: Linting PocketCasts with this PR took 6.88s vs 7.05s on main (2% faster)
:book: Linting Quick with this PR took 0.37s vs 0.38s on main (2% faster)
:book: Linting Realm with this PR took 4.15s vs 4.13s on main (0% slower)
:book: Linting Sourcery with this PR took 2.11s vs 2.05s on main (2% slower)
:book: Linting Swift with this PR took 3.94s vs 3.85s on main (2% slower)
:book: Linting VLC with this PR took 1.1s vs 1.1s on main (0% slower)
:book: Linting Wire with this PR took 14.82s vs 14.76s on main (0% slower)
:book: Linting WordPress with this PR took 9.65s vs 9.83s on main (1% faster)

Generated by :no_entry_sign: Danger

SimplyDanny commented 1 month ago

I'd appreciate your feedback on this @mildm8nnered as you have provided the initial implementation of this rule. This is the last issue reported after the 0.55.0 release. Once it's merged, I may cut 0.55.1.