search

realm / SwiftLint

A tool to enforce Swift style and conventions.
https://realm.github.io/SwiftLint
MIT License
18.45k stars 2.2k forks source link

Rule Request: [empty_catch] #5634

Open 72A12F4E opened 1 week ago

72A12F4E commented 1 week ago

New Issue Checklist

New rule request

Please describe the rule idea, format this issue's title as Rule Request: [Rule Name] and describe:

  1. Why should this rule be added? Share links to existing discussion about what the community thinks about this.

I think we should have a rule that triggers when someone writes a do-catch, and leaves the catch empty. Cases like this should just use try?

  1. Provide several examples of what would and wouldn't trigger violations.

Bad

do {
    try doStuff()
} catch {

}

Good

do {
    try doStuff()
} catch {
   Logger().error("\(error.localizedDescription)")
}
  1. Should the rule be configurable, if so what parameters should be configurable?

no configuration needed

  1. Should the rule be opt-in or enabled by default? Why? See README.md for guidelines on when to mark a rule as opt-in.

I think this should be enabled by default, although I can understand the amount of noise that might cause for existing projects.

SimplyDanny commented 1 week ago

This could become a part of the new rule introduced in #5617 or a dedicate rule.