Closed mildm8nnered closed 3 weeks ago
The PR to update it got stuck in the macOS 12 build with a for me yet unclear error. I've set up jobs to test macOS versions that SwiftLint still claims to support and that are older than the latest version used in all existing general build tasks. The job for macOS 12 fails as well. So this seems to be a real issue we need to investigate.
Please feel free to support while I'm currently not working on it.
I can try to take a look, although I'm not that familiar with the home-brew stuff, except as a user.
From the pre-test steps
on the failed CI job at https://github.com/Homebrew/homebrew-core/actions/runs/10273598571/job/28428511893?pr=180295 for macOS 12 ARM64, it says Xcode: 14.2
What actually needs to run on macOS12 - I don't think we can actually build on there because we require Xcode 15 I think (e.g. Xcode 14.3.1 fails for me with "package 'swiftlint' is using Swift tools version 5.9.0 but the installed version is 5.8.0".)
SwiftLint doesn't actually have a dependency on Xcode. The previous release was already built with plain Swift toolchains on macOS 12 and 13 in Homebrew. This is specified in the Homebrew formula for SwiftLint:
depends_on xcode: "8.0"
uses_from_macos "swift"
on_sonoma :or_newer do
depends_on xcode: ["15.3", :build]
end
on_ventura :or_older do
depends_on "swift" => :build
end
Perhaps this is a SwiftSyntax issue which I reported in https://github.com/swiftlang/swift-syntax/issues/2784. At least the folks there might be able to help out.
So that ticket has some responses which sound promising
Looks like https://github.com/swiftlang/swift-syntax/issues/2784 lead to https://github.com/swiftlang/swift-syntax/pull/2801, which has been merged.
It looks like swift-syntax tagged a new pre-release that includes the change: https://github.com/swiftlang/swift-syntax/releases/tag/600.0.0-prerelease-2024-08-14
Does this unblock update homebrew?
Blocking was that SwiftLint didn't build on macOS 12 (independent of the changes in SwiftSyntax). We excluded the version and now 0.56.1 is available via Homebrew on macOS 13 and 14 at least.