Still cannot run swiftlint on circleci

realm / SwiftLint

A tool to enforce Swift style and conventions.

https://realm.github.io/SwiftLint

MIT License

18.47k stars 2.2k forks source link

Still cannot run swiftlint on circleci #593

Closed brennantaylor closed 8 years ago

brennantaylor commented 8 years ago

Still getting dyld: Library not loaded

I saw an issue was closed earlier but it doesn't look resolved.

In another project, swiftgen, it looks like a workaround was done in homebrew by not pouring from bottle if there is no /Applications/Xcode.app. https://github.com/Homebrew/homebrew/pull/45008

This would at least get it running for now.

norio-nomura commented 8 years ago

Thanks for reporting. We have PR #555 that will resolve this issue.

brennantaylor commented 8 years ago

Oh I'm sorry I should have looked through the open pull requests more closely.

Thanks for the update!

jpsim commented 8 years ago

@brennantaylor how's this looking now that #555's been merged?

brennantaylor commented 8 years ago

@jpsim I can't seem to compile HEAD with brew at the moment. Since there is no release either I can't easily install on circle. I can test as soon as the next release comes out.

brew install --HEAD swiftlint says ** CLEAN SUCCEEDED ** but then exits uncleanly.

norio-nomura commented 8 years ago

@brennantaylor That issue has been reproduced on my local mac. It seems that is same as https://github.com/Carthage/Carthage/issues/1243

norio-nomura commented 8 years ago

SwiftLint 0.10.0 has been released and is expected to run on CircleCI with brew install swiftlint.

jpsim commented 8 years ago

If someone confirms that it works, we'll close this issue, so just let us know!

mikemee commented 8 years ago

This worked on CircleCI just now:

SwiftLint installed ok with brew install swiftlint (see below)
the previous warning about SwiftLint not being installed went away
the build succeeded
an intentional fatal SwiftLint error in my code made the build fail
warnings did not fail (nor did they display anything in the logs -- I'll be making more warnings fail soon!)

Fwiw, my circle.yml file was (Carthage references left there to avoid unintentionally editing away some crucial detail, but see here if you're interested):

general:
  branches:
    only:
      - master

machine:
  xcode:
    version: 7.3.1

dependencies:
  override:
    - brew install swiftlint
    - bin/bootstrap-if-needed
  cache_directories:
    - "Carthage"

Awesome awesome tool. Thanks Realm for making it available and supporting it. (And, together with the video transcriptions, this made me find realm and now I'm using it my apps...)

jpsim commented 8 years ago

Great to hear this works now 😄