realm / aws-devicefarm

Github action for triggering runs on AWS devicefarm
MIT License
17 stars 10 forks source link

Adding ability to install auxiliary apps #20

Open nhachicha opened 8 months ago

nhachicha commented 8 months ago

Some Tests setup requires the existence of other apps on the device. This PR support the auxiliaryApps configuration parameter which will upload the configured apps prior to the test execution. This is currently used in https://github.com/realm/realm-kotlin/pull/1605/files#diff-604f50a605b704c73aa4474fbdb263cda70a027db332d04bab7d464fdc042176R29

nhachicha commented 8 months ago

cc @bwachter @nirinchev @cmelchior

bwachter commented 8 months ago

Code looks good, but please also update the documentation. Also it'd be nice to have this case also tested in the integration test run.

Please rebase before pushing changes, I've just merged the change making pull requests use the production environment (for some reason didn't get notified it was reviewed), and rebase on your side is probably required for it to pick up those changes.