search

realm / aws-devicefarm

Github action for triggering runs on AWS devicefarm
MIT License
17 stars 10 forks source link

Update to node16 and cleanup node_modules #9

Closed nirinchev closed 1 year ago

nirinchev commented 1 year ago

This updates actions to node16 as node12 is deprecated. Additionally, I noticed we're committing node_modules which is a bad practice. I've deleted the folder and added a .gitignore.

bwachter commented 1 year ago

https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github

"GitHub downloads each action run in a workflow during runtime and executes it as a complete package of code before you can use workflow commands like run to interact with the runner machine. This means you must include any package dependencies required to run the JavaScript code."

nirinchev commented 1 year ago

Yes, the recommended way to do it is via ncc, not by checking in node_modules. I've added a build script that compiles the dependencies into a single file.

bwachter commented 1 year ago

Looks good to me. Switching bool input handling over to getBooleanInput is tracked in #11 - my best guess still is that something weird was going on in input validation there.