realm / realm-core

Core database component for the Realm Mobile Database SDKs
https://realm.io
Apache License 2.0
1.02k stars 165 forks source link

Metrics_TransactionTimings sometimes fails with "failed with (0, 0)" #6164

Open sync-by-unito[bot] opened 1 year ago

sync-by-unito[bot] commented 1 year ago

Update the Metrics_TransactionTimings test to look for greater than or equal instead of greater than, since the test sometimes fails with CHECK_GREATER(transactions->at(3).get_fsync_time_nanoseconds(), 0) failed with (0, 0) even though the test was successful.

Example: https://spruce.mongodb.com/task/realm_core_stable_windows_64_vs2019_release_core_tests_patch_818562016f7a903d9f72a571d995b17661f39432_63b48d167742ae0d50be99d2_23_01_03_20_16_22/logs?execution=0&sortBy=STATUS&sortDir=ASC

[2023/01/03 20:33:49.231] 1: Thread[5]: C:\data\mci\11bdcc3981b6923fd2593d36de84f8b2\realm-core\test\test_metrics.cpp:722: Begin Metrics_TransactionTimings
[2023/01/03 20:33:49.397] 1: Thread[5]: C:\data\mci\11bdcc3981b6923fd2593d36de84f8b2\realm-core\test\test_metrics.cpp:799: ERROR in Metrics_TransactionTimings: CHECK_GREATER(transactions->at(3).get_fsync_time_nanoseconds(), 0) failed with (0, 0)
sync-by-unito[bot] commented 1 year ago

➤ michael-wb commented:

Re-opened task since failures were still being observed after the changes were integrated: https://spruce.mongodb.com/task/realm_core_stable_rhel70_core_tests_patch_5a119d8cb2eaac60c298532af2c9ae789af0c9e6_63c5387232f4171734d05f23_23_01_16_11_43_47/tests?execution=0&sortBy=STATUS&sortDir=ASC