realm / realm-core

Core database component for the Realm Mobile Database SDKs
https://realm.io
Apache License 2.0
1.02k stars 165 forks source link

Remove 308 redirect support from App/AppUser #7942

Open sync-by-unito[bot] opened 3 months ago

sync-by-unito[bot] commented 3 months ago

We have a bunch of code that tries to handle 308 HTTP redirects received from BAAS, but it turns out that all-but-one of the implementations of the GenericNetworkTransport follow 308-redirects transparently and the server doesn't actually send any 308 redirects, so our handling of 308 redirects is actually dead code in production. We should remove all the redirect handling code and any associated tests to simplify the codebase.

sync-by-unito[bot] commented 3 months ago

➤ PM Bot commented:

Jira ticket: RCORE-2222

sync-by-unito[bot] commented 3 months ago

➤ michael-wb commented:

The CPP SDK should probably add redirect support before releasing this set of changes. They are using the http client from Realm Core networking, so it could potentially be added to the callback handler that receives the http response.

sync-by-unito[bot] commented 3 months ago

➤ michael-wb commented:

The redirect support will be removed and the following items will be retained: