Closed michael-wb closed 2 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
test/object-store/sync/app.cpp | 157 | 161 | 97.52% | ||
<!-- | Total: | 157 | 161 | 97.52% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/realm/array_backlink.cpp | 1 | 91.38% | ||
src/realm/object-store/sync/app_utils.cpp | 1 | 96.15% | ||
src/realm/sort_descriptor.cpp | 1 | 94.06% | ||
src/realm/sync/noinst/server/server_history.cpp | 1 | 62.92% | ||
test/object-store/sync/app.cpp | 1 | 98.87% | ||
test/test_dictionary.cpp | 1 | 99.83% | ||
src/realm/list.cpp | 2 | 87.37% | ||
src/realm/object-store/sync/sync_session.cpp | 2 | 91.84% | ||
src/realm/util/uri.cpp | 2 | 96.32% | ||
test/object-store/util/test_file.cpp | 2 | 87.06% | ||
<!-- | Total: | 134 | --> |
Totals | |
---|---|
Change from base Build 2586: | -0.05% |
Covered Lines: | 217172 |
Relevant Lines: | 238402 |
Should we add a test that makes the synchronous CURL http lib follow redirects, and setup a redirecting server the issues a 308 and make sure we can sync with that?
Should we add a test that makes the synchronous CURL http lib follow redirects, and setup a redirecting server the issues a 308 and make sure we can sync with that?
I would be happy to do this in a separate PR - the test that I am adding for the CPP SDK will also be doing this.
What, How & Why?
Since the redirection 301/308 support is being removed, the tests are no longer needed. The first part of these changes is to remove the redirect tests.
Fixes #7942
☑️ ToDos
[ ] 📝 Changelog update[ ] C-API, if public C++ API changed[ ]bindgen/spec.yml
, if public C++ API changed