Closed michael-wb closed 2 months ago
michael-wb
commented
3 months ago Is this reverting to the state before supporting redirection?
Technically yes - the redirection is being removed since there is already support for handling 301/308 redirections in the HTTP transport supplied by the SDK and Core will never actually see a 301/308 response. The only exception to this is the CPP SDK, and I am working on that now so it supports redirections as well.
danieltabacaru
commented
3 months ago Technically yes - the redirection is being removed since there is already support for handling 301/308 redirections in the HTTP transport supplied by the SDK and Core will never actually see a 301/308 response. The only exception to this is the CPP SDK, and I am working on that now so it supports redirections as well. Is the CPP support already handled in this PR?
michael-wb
commented
3 months ago Unfortunately not, I created https://github.com/realm/realm-cpp/issues/239 for adding redirection support in the CPP SDK.
coveralls-official[bot]
commented
3 months ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/realm/object-store/sync/app.cpp | 40 | 44 | 90.91% | ||
| <!-- | Total: | 40 | 44 | 90.91% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/realm/array_string.cpp | 1 | 88.03% | ||
| src/realm/mixed.cpp | 1 | 86.61% | ||
| src/realm/sync/noinst/server/server.cpp | 1 | 74.69% | ||
| src/realm/uuid.cpp | 1 | 98.48% | ||
| test/test_index_string.cpp | 1 | 93.48% | ||
| src/realm/sync/noinst/client_impl_base.cpp | 2 | 82.83% | ||
| test/object-store/sync/flx_sync.cpp | 2 | 98.35% | ||
| test/test_lang_bind_helper.cpp | 2 | 93.2% | ||
| src/realm/query_expression.hpp | 3 | 93.85% | ||
| test/fuzz_tester.hpp | 5 | 57.18% | ||
| <!-- | Total: | 79 | --> |
| Totals | |
|---|---|
| Change from base Build 2594: | 0.002% |
| Covered Lines: | 217173 |
| Relevant Lines: | 238374 |
What, How & Why?
Removes the 301/308 http redirection support from the app services support in
App. The redirection tests have been removed in PR #7994.Fixes #7942
☑️ ToDos
[ ] 🚦 Tests (or not relevant)[ ] C-API, if public C++ API changed[ ]bindgen/spec.yml, if public C++ API changed