jedelbo
commented
2 months ago The added test should match this one: https://github.com/realm/realm-core/pull/7987#issuecomment-2322058251 But the test does not fail. @tgoyne where am I mistaken.
Closed jedelbo closed 2 months ago
jedelbo
commented
2 months ago The added test should match this one: https://github.com/realm/realm-core/pull/7987#issuecomment-2322058251 But the test does not fail. @tgoyne where am I mistaken.
coveralls-official[bot]
commented
2 months ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/realm/list.cpp | 1 | 87.37% | ||
| src/realm/sort_descriptor.cpp | 1 | 94.06% | ||
| src/realm/util/serializer.cpp | 1 | 90.43% | ||
| src/realm/object-store/shared_realm.cpp | 2 | 91.9% | ||
| src/realm/sync/network/http.hpp | 2 | 82.27% | ||
| src/realm/sync/instruction_applier.cpp | 3 | 68.01% | ||
| src/realm/sync/noinst/protocol_codec.hpp | 3 | 76.27% | ||
| src/realm/util/future.hpp | 3 | 95.94% | ||
| test/fuzz_group.cpp | 3 | 47.53% | ||
| src/realm/table.cpp | 4 | 90.55% | ||
| <!-- | Total: | 68 | --> |
| Totals | |
|---|---|
| Change from base Build 2595: | 0.005% |
| Covered Lines: | 217168 |
| Relevant Lines: | 238382 |
jedelbo
commented
2 months ago It turns out that the Swift test was verifying the wrong behavior. It would not harm to add this test anyway.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed