realm / realm-core

Core database component for the Realm Mobile Database SDKs
https://realm.io
Apache License 2.0
1.02k stars 165 forks source link

RCORE:2259: Fix comparison function for ConditionType #8029

Closed jedelbo closed 2 months ago

jedelbo commented 2 months ago

The function should ensure strict weak ordering. According to the current one {1, 0} == {0, 1} and {0, 1} == {2, 1} but {1, 0} < {2, 1}

It is not possible to construct a failing test as the outcome very much depends on how the runtime types are laid out.

What, How & Why?

Fixes #8028

☑️ ToDos

coveralls-official[bot] commented 2 months ago

Pull Request Test Coverage Report for Build jorgen.edelbo_429

Details


Files with Coverage Reduction New Missed Lines %
src/realm/sync/noinst/changeset_index.cpp 1 79.47%
test/test_util_network_ssl.cpp 1 89.59%
src/realm/mixed.cpp 2 86.46%
test/object-store/util/test_file.cpp 2 87.06%
test/test_lang_bind_helper.cpp 2 93.2%
src/realm/table.cpp 3 90.29%
src/realm/sync/noinst/client_impl_base.cpp 4 82.67%
src/realm/sync/noinst/protocol_codec.hpp 6 75.74%
test/fuzz_group.cpp 6 45.14%
<!-- Total: 27 -->
Totals Coverage Status
Change from base Build 2612: 0.03%
Covered Lines: 217201
Relevant Lines: 238389

💛 - Coveralls