search

realm / realm-java

Realm is a mobile database: a replacement for SQLite & ORMs
http://realm.io
Apache License 2.0
11.45k stars 1.75k forks source link

Sort annotated classes to process #7616

Closed jprinet closed 2 years ago

jprinet commented 2 years ago

This is an easy sort which should cover the ordering issue. There are probably some ways to change the ordering earlier but this approach has the advantage of minimizing the change set.

There is some other randomness on classes iteration but this has no effect on the generated source code.

cla-bot[bot] commented 2 years ago

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @jprinet. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

jprinet commented 2 years ago

@cla-bot check

cla-bot[bot] commented 2 years ago

The cla-bot has been summoned, and re-checked this pull request!

cmelchior commented 2 years ago

Hi @jprinet Thank you very much for reporting and fixing this. Unfortunately, our CI pipeline doesn't run on external contributions right now, and when I ran tests locally, I noticed that this change broke one of our unit tests. So I took the liberty of making the necessary fixes in this PR https://github.com/realm/realm-java/pull/7617

jprinet commented 2 years ago

Hi @jprinet Thank you very much for reporting and fixing this. Unfortunately, our CI pipeline doesn't run on external contributions right now, and when I ran tests locally, I noticed that this change broke one of our unit tests. So I took the liberty of making the necessary fixes in this PR #7616

Please feel free to add any necessary change. I had some hard times trying to setup a unit test for this change and thought that it would be a better idea to leave it to you anyway.

And sorry for breaking the tests, I had to disable locally some parts of the builds as the native compilation was failing for some reasons.

cmelchior commented 2 years ago

A 10.10.0-SNAPSHOT has been released with this fix: https://github.com/realm/realm-java#using-snapshots

jprinet commented 2 years ago

A 10.10.0-SNAPSHOT has been released with this fix: https://github.com/realm/realm-java#using-snapshots

awesome, thanks for being so prompt!