realm / realm-js

Realm is a mobile database: an alternative to SQLite & key-value stores
https://realm.io
Apache License 2.0
5.72k stars 564 forks source link

[Android] Unify CMake #3660

Open kneth opened 3 years ago

kneth commented 3 years ago

Currently we are using upstream CMake for node.js and a patched CMake for Android.

Once Android NDK r23 and CMake v3.20 have been released, we should be able to use upstream CMake only.

Moreover, using the unified CMake, we will also be able to do LTO to reduce the size of binary files (see https://github.com/realm/realm-js/issues/3637).

It might be beneficial to work on this issue together with https://github.com/realm/realm-js/issues/3652.

kraenhansen commented 1 month ago

As we're building with NDK r25 now - it might make sense to revisit this?