search

realm / realm-js

Realm is a mobile database: an alternative to SQLite & key-value stores
https://realm.io
Apache License 2.0
5.8k stars 577 forks source link

Upgrade actions #6425

Open kraenhansen opened 9 months ago

kraenhansen commented 9 months ago

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

takameyer commented 9 months ago

I've hit a few of them, but there are a few left that need to be updated by the maintainers:

One larger issue at hand is upload-artifact. This we could upgrade to, but it contains a breaking change which hinders how we deal with prebuilds currently. Each artifact uploaded must have a unique key, otherwise it fails. In v3, one could use the same key and it would append the artifact into the previous. While it is possible to refactor the testing workflow to handle this, our release pipelines would need a bit more assistance, as they currently pull the single prebuild artifact into the packaged release.