realm / realm-js

Realm is a mobile database: an alternative to SQLite & key-value stores
https://realm.io
Apache License 2.0
5.6k stars 558 forks source link

Ensure we have `clang-format` installed on CI runners when generating bindings #6594

Closed kraenhansen closed 2 weeks ago

kraenhansen commented 3 weeks ago

With the merge of https://github.com/realm/realm-core/pull/7554 we'll need to ensure that any workflows which are generating C++ binding code has a clang-format executable installed. This is mostly a reminder to the next person upgrading core and wondering why generating the binding is failing.

We should also update our contrib docs to mention the need to install it.

sync-by-unito[bot] commented 3 weeks ago

➤ PM Bot commented:

Jira ticket: RJS-2791

kraenhansen commented 2 weeks ago

This was handled by the added dependency on trunk in https://github.com/realm/realm-js/pull/6598.