search

realm / realm-js

Realm is a mobile database: an alternative to SQLite & key-value stores
https://realm.io
Apache License 2.0
5.61k stars 558 forks source link

Run React Native integration tests in more configurations #6604

Open kraenhansen opened 2 weeks ago

kraenhansen commented 2 weeks ago

In the context of https://github.com/reactwg/react-native-new-architecture/discussions/167#discussioncomment-9056655 I suggest we start running our integration tests with different values for "hermes", "new arch" and "bridgeless". Since this adds complexity, multiplying the risk of some test failing as a result of any unstable test, running these additional tests should probably require a manual dispatch or a special label on the PR.

These configurations can be controlled by setting different values of the environment variables declared here (seems we're missing bridgeless for iOS):

https://github.com/realm/realm-js/blob/2e31a271da0cec07274e52ee97691531bc1039dd/integration-tests/environments/react-native-test-app/package.json#L30-L41

https://github.com/realm/realm-js/blob/2e31a271da0cec07274e52ee97691531bc1039dd/integration-tests/environments/react-native-test-app/package.json#L88-L95

sync-by-unito[bot] commented 2 weeks ago

➤ PM Bot commented:

Jira ticket: RJS-2797

kraenhansen commented 2 weeks ago

This draft PR is somewhat related: https://github.com/realm/realm-js/pull/5369