search

realm / realm-js

Realm is a mobile database: an alternative to SQLite & key-value stores
https://realm.io
Apache License 2.0
5.62k stars 558 forks source link

RJS-2717: Replaced lodash with lodash.isequal #6633

Open Ydixit007 opened 3 weeks ago

Ydixit007 commented 3 weeks ago

What, How & Why?

Since we're only using isEqual from lodash we should avoid requiring in the entire library as it'll be difficult for end-users to shake off. Instead we could depend on the more limited lodash.isequal package.

This closes #6458 .

cla-bot[bot] commented 3 weeks ago

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @Ydixit007. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

Ydixit007 commented 3 weeks ago

@cla-bot check

cla-bot[bot] commented 3 weeks ago

The cla-bot has been summoned, and re-checked this pull request!

kraenhansen commented 3 weeks ago 
npm ERR! Missing: @types/lodash.isequal@4.5.8 from lock file
npm ERR! Missing: lodash.isequal@4.5.0 from lock file

You'll need to run npm install and commit the changes to the lock file đź‘Ť