search

realm / realm-js

Realm is a mobile database: an alternative to SQLite & key-value stores
https://realm.io
Apache License 2.0
5.76k stars 572 forks source link

Refactor `ProgressRealmPromise` to register progress notifier only if needed #6685

Open kraenhansen opened 4 months ago

kraenhansen commented 4 months ago

Refactor ProgressRealmPromise to only register a progress notification when a user of the SDK actually ask for progress: https://github.com/realm/realm-js/blob/fc633f70b69596d84f7dce5a2d7f1fac9f8e25e1/packages/realm/src/ProgressRealmPromise.ts#L168-L171

We register the listener right away: https://github.com/realm/realm-js/blob/fc633f70b69596d84f7dce5a2d7f1fac9f8e25e1/packages/realm/src/ProgressRealmPromise.ts#L137-L139C52

sync-by-unito[bot] commented 4 months ago

➤ PM Bot commented:

Jira ticket: RJS-2823