Realm Tasks Migration to Swift 3

realm / realm-tasks

To Do app built with Realm, inspired by Clear for iOS

Other

368 stars 73 forks source link

Realm Tasks Migration to Swift 3 #357

Closed TimOliver closed 7 years ago

TimOliver commented 7 years ago

A non-trivial PR; this converts the entire codebase of Realm Tasks for both macOS and iOS to Swift 3, allowing for the latest dependencies to subsequently be integrated.

There may still be some code issues in certain places, and certain things might be able to be converted more cleanly (There are a few NSError to Error compatibility sections that come to mind), but for now, I'd love a second pair of eyes to have a look at it so far. :)

/cc @jpsim @stel

TimOliver commented 7 years ago

Thanks for the input @stel and @jpsim! I've followed up the PR with all of your feedback. Let me know what you think!

TimOliver commented 7 years ago

Thanks a lot @stel! No I haven't got anything specific that needs checking anymore. :)