search

realm / realm-tasks

To Do app built with Realm, inspired by Clear for iOS
Other
369 stars 71 forks source link

[Android] update Realm Java to 3.3.2 and realm-android-adapter to 2.1.0 #405

Closed zaki50 closed 7 years ago

zaki50 commented 7 years ago

I've created a PR to update Realm and Realm-android-adapters @dalinaum

Zhuinden commented 7 years ago

I guess suppressing the RealmChangeListeners is no longer necessary with Realm 3.1 and synchronous call to change listeners at commitTransaction()?

@beeender ?

beeender commented 7 years ago

Right, we should not need suppressing listeners. @zaki50 Shall we update this PR?

dalinaum commented 7 years ago

I don't encounter a kind of exception with the latest Realm Java yet. It seems fixed already.

Changing colors doesn't work correctly. I think some behavior changes of adapter or Realm itself, influence this. I should look into this issue. Please wait until I will find something. @zaki50 @cmelchior

Zhuinden commented 7 years ago

@nnrealm the notifyItem* calls should be removed, but the few notifyDataSetChanged() calls should be kept.

Also should probably bump to Realm 3.4.0 although that is of minimal change.

Zhuinden commented 7 years ago

@nnrealm I don't think it's broken, just old (2.3.0).

I am not a Realm person, but I did need to update the sample to Realm 3.x once before 😄

dalinaum commented 7 years ago

I will look this issue soon, but it needs some time to investigate some weird artifacts.

cmelchior commented 7 years ago

Replaced by #428