realmazharhussain / gdm-tools

(Deprecated) Command-line tools for GNOME's login manager, GDM
GNU General Public License v3.0
95 stars 4 forks source link

Changing gdm theme makes the close button on the overview missing #13

Closed radical4ever closed 2 years ago

radical4ever commented 2 years ago

hi, when i change the theme and log out and log in, the close button on the overview appears missing.

realmazharhussain commented 2 years ago

What theme are you using? And where did you get that theme?

radical4ever commented 2 years ago

What theme are you using? And where did you get that theme?

For gtk theme i use Graphite from vinceluice i got it from github, icons im using papirus (github too) but it happens on all icon theme.

realmazharhussain commented 2 years ago

Graphite (like many other Gnome Shell themes) is incomplete. That's why you are having such problems.

But don't worry. I will be adding an --overlay-mode option to set-gdm-theme command which will ensure that icons and other resources from default theme are added to the theme being applied if it does not already contain those resources.

For now, run the following commands to fix those issues

set-gdm-theme -x
themesDir=/usr/share/themes
scalableDir=gnome-shell/icons/scalable
for GraphiteDir in $themesDir/Graphite-*; do
  for resource in actions/preview-close-symbolic.svg status/eye-{not-looking,open-negative-filled}-symbolic.svg; do
    sudo install -Dm644 $themesDir/default-extracted/$scalableDir/$resource $GraphiteDir/$scalableDir/$resource
  done
done
set-gdm-theme -s -b
realmazharhussain commented 2 years ago

overlayMode has been added as a configuration option and its default value is resources.

It means your problem has been solved.

If you ever want to restore the previous behavior set overlayMode variable in /etc/gdm-tools/set-gdm-theme.conf to none.

realmazharhussain commented 2 years ago

Please! Update gdm-tools and Check if the fix works for you; And if it does, report back to me.

radical4ever commented 2 years ago

Thanks!, now it works fine the close button is no longer missing and the show password button on gdm is no longer missing too. thanks for the help!!

realmazharhussain commented 2 years ago

You are welcome