Closed BVengo closed 1 year ago
Some basic MR (Merge/Pull Request) ethics include;
The docstrings you have added and the changes you have made in commit 2dfae6de6183ffd4f27e4aa046ad8fd3211ebda2 violate both of these ethics. They are good changes but do not belong in this MR.
Please, fix your MR. Thanks.
My mistake, thanks for the info! I've removed all extra docstrings and refactoring.
Thank you for all this work.
Now, one final change remains. There should only be two commits:
Every other change should be squashed into these commits.
Thanks for your patience - clearly I don't make pull requests often!
Changes are all squashed, and it should be good to go.
Also, I revisited issue #9 and this does not resolve #9. The author of #9 specifically mentions JetBrains Toolbox.
So, please, remove the mention of #9 from the MR description. Thanks.
All of these apply to installations via Jetbrains Toolbox as well, since it creates links for the native commands.
I'll update the description to specify that.
On Wed, 22 Mar 2023, 18:18 Mazhar Hussain, @.***> wrote:
Also, I revisited issue #9 https://github.com/realmazharhussain/nautilus-code/issues/9 and this does not resolve #9 https://github.com/realmazharhussain/nautilus-code/issues/9. The author of #9 https://github.com/realmazharhussain/nautilus-code/issues/9 specifically mentions JetBrains Toolbox.
So, please, remove the mention of #9 https://github.com/realmazharhussain/nautilus-code/issues/9 from the MR description. Thanks.
— Reply to this email directly, view it on GitHub https://github.com/realmazharhussain/nautilus-code/pull/22#issuecomment-1479026920, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIG2KHZNJYBPCP2GQP5WXTW5KRTRANCNFSM6AAAAAAWDJMB7U . You are receiving this because you authored the thread.Message ID: @.***>
it creates links for the native commands
Really! I didn't know that. That's great.
Yep! Very useful, and I checked them all to make sure they all did it by default.
Hi, git works in fricking mysterious ways. Can you re-open the MR after re-pushing to your main branch? Thanks.
I noticed that, and it's confused me to no end.
Will re-open in 15 once I get home again.
On Wed, 22 Mar 2023, 18:51 Mazhar Hussain, @.***> wrote:
Hi, git works in fricking mysterious ways. Can you re-open the MR after re-pushing to your main branch? Thanks.
— Reply to this email directly, view it on GitHub https://github.com/realmazharhussain/nautilus-code/pull/22#issuecomment-1479055556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIG2KC4G2HLC4WP3355RGTW5KVQ7ANCNFSM6AAAAAAWDJMB7U . You are receiving this because you authored the thread.Message ID: @.***>
Added native and flatpak support for Jetbrains IDEs.
All of these apply to installations via Jetbrains Toolbox as well, since it creates links for the native commands (resolves #9).
Every new IDE was installed and tested (both Native and Flatpak) to confirm that they open projects as expected and don't require additional arguments. Language support will still need updating with all the new IDEs, however I also noticed that many of the translation files already had incorrect line numbers in the comments.
List of Jetbrains IDEs: