search

realnc / SDL_audiolib

An audio decoding, resampling and mixing library for SDL.
GNU Lesser General Public License v3.0
43 stars 8 forks source link

CMake: Remove `link_directories` #14

Closed glebm closed 3 years ago

glebm commented 3 years ago

link_directories is unnecessary, CMake's targets take care of the correct linking.

realnc commented 3 years ago

You still need the directories. But I think it's supposed to be target_link_directories nowadays instead of link_directories? Should probably be placed right above the existing target_link_libraries.

But I think that requires raising minimum cmake version from 3.8 to 3.13.

glebm commented 3 years ago

Fixed, we don't need link_directories after all :)