search

realnc / SDL_audiolib

An audio decoding, resampling and mixing library for SDL.
GNU Lesser General Public License v3.0
43 stars 8 forks source link

Compiler warnings #27

Open AJenbo opened 3 years ago

AJenbo commented 3 years ago

These are now the only compiler warnings left when building DevilutionX, would be great if we can handle them so we can start checking for compiler warnings in the CI :)

In file included from /home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample.c:100:
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample_sse.h:45:14: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
   for (i=0;i<len;i+=8)
            ~^~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample_sse.h:62:12: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
  for(i=0;i<len;i+=2)
          ~^~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample_sse.h:84:14: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
   for (i=0;i<len;i+=8)
            ~^~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample_sse.h:110:12: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
  for(i=0;i<len;i+=2)
          ~^~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample.c:674:20: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
         for (j=0;j<st->filt_len;j++)
                  ~^~~~~~~~~~~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample.c:946:21: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
           for(j=0;j<ichunk;++j)
                   ~^~~~~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample.c:949:20: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
          for(j=0;j<ichunk;++j)
                  ~^~~~~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample.c:1001:19: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
         for(j=0;j<ichunk;++j)
                 ~^~~~~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample.c:1008:19: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
         for(j=0;j<ichunk;++j)
                 ~^~~~~~~
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/3rdparty/speex_resampler/resample.c:1018:16: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
     for (j=0;j<ochunk+omagic;++j)
              ~^~~~~~~~~~~~~~
[ 46%] Built target StormLib
10 warnings generated.
/home/ajenbo/code/diablo/devilutionX/buildclang/_deps/sdl_audiolib-src/src/Decoder.cpp:54:10: warning: unused variable 'tryDecoder' [-Wunused-variable]
    auto tryDecoder = [rwops, &rewindRwops](auto dec) {
         ^
realnc commented 3 years ago

I pushed a fix for the Decoder.cpp warning. As for the resampler, you'd have to bug upstream about it:

https://gitlab.xiph.org/xiph/opus-tools

:-P

AJenbo commented 3 years ago

https://gitlab.xiph.org/xiph/opus-tools/-/issues/2317