realpython / dockerizing-django

https://realpython.com/blog/python/django-development-with-docker-compose-and-machine/
1.34k stars 484 forks source link

Aren't there secure issues since we expose 6379:6379 #35

Open FingerLiu opened 8 years ago

FingerLiu commented 8 years ago

https://github.com/realpython/dockerizing-django/blob/master/docker-compose.yml wrote

redis:
  restart: always
  build: ./redis
  ports:
    - "6379:6379"

I think this may expose 6379 to the whole internet? Although in production.yml changed to

ports:
  - "6379"

it expose a random port to the whole internet

And from compose file reference https://docs.docker.com/compose/compose-file/#/ports there is a format

ports:
   - "127.0.0.1:8001:8001"

Would this be safer? Any ideas?