Closed vire closed 7 years ago
Merging #73 into master will decrease coverage by
2.09%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #73 +/- ##
=========================================
- Coverage 17.15% 15.05% -2.1%
=========================================
Files 10 14 +4
Lines 309 352 +43
Branches 50 45 -5
=========================================
Hits 53 53
- Misses 256 299 +43
Impacted Files | Coverage Δ | |
---|---|---|
src/js/contentscript.js | 0% <0%> (ø) |
:arrow_up: |
src/js/popup/Popup.vue | 60% <0%> (-17.78%) |
:arrow_down: |
src/js/components/Availability.vue | 0% <0%> (ø) |
:arrow_up: |
src/js/popup.js | 0% <0%> (ø) |
:arrow_up: |
src/js/services/storage.js | 0% <0%> (ø) |
:arrow_up: |
src/js/services/api.js | 0% <0%> (ø) |
:arrow_up: |
src/js/components/App.vue | 0% <0%> (ø) |
:arrow_up: |
src/js/utils.js | 0% <0%> (ø) |
:arrow_up: |
src/js/sites/fixtures/bezrealitky.js | 100% <0%> (ø) |
|
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 02dd718...d2e13ad. Read the comment docs.
PR is ready to be merged
@vire lucky, that I am so slow :) btw change PR nam to WIP: .... (WIP as Work In Progress)
@vire and what about last unchecked item "semantic release plugin" ? I am ok with that and thank you as always. You can merge it by yourself if it's ready.
@michalbcz I need to check out how the semantic-versioning plugin works on a non-npm project like this. We don't actually release a npm package called reality-plugin
but the semantic-versioning
is designed exactly for this. But as a bonus it makes use of the https://github.com/conventional-changelog/conventional-changelog and takes care of versions.
So for now, I remove the checkbox from this PR and create a separate issue for that.
And for future WIP: label is a perfect choice ;) or 🚧 emoji
+1 for that emoji :)