realthecaffiend / SOS2ExpSpinalEngines

An addon for beeg SOS2 engines
MIT License
0 stars 2 forks source link

Engines visually firing #20

Closed realthecaffiend closed 2 months ago

realthecaffiend commented 2 months ago

Discord report, at least one instance of invalidated (removed subparts) engines visually firing during combat

Suspicion: Some interaction with the "single engine firing bug" that may be related to wrecks, in base SOS2? Otherwise, some failure to invalidate the engine when a part is removed, or no longer correctly invalidated for canFire?

realthecaffiend commented 2 months ago

Not required to have any of that bug at all: Canfire iterates all engines and just has basic checks. Smashing a part in-game removes the engine from the cache.... But loading a save adds it. NTS, postfix (prefix? Extend?) CanFire

realthecaffiend commented 2 months ago

Fixed* Pending both my PR to SOS2 as well as updating to new refactored version