realtimeradio / vla-dev

Ethernetization/Channelization Firmware for the VLA-COSMIC FPGA system
GNU General Public License v3.0
1 stars 3 forks source link

Lo `get_status` implementation #23

Closed jack-h closed 2 years ago

jack-h commented 2 years ago

The Lo block should implement get_status() -- probably this should just return all the currently loaded LO shift frequencies, in friendly printable units

jack-h commented 2 years ago

To be annoying -- get_status is a method of the Block parent class, so should comply with the API of that (i.e., return a pair of dictionaries, one containing status key/vals, the other containing warning codes (of which probably there aren't any here, so the error dict would just be {})

jack-h commented 2 years ago

https://github.com/realtimeradio/vla-dev/blob/d8afc10119d10ec0e4ef5374493814f11f6585b9/software/control_sw/src/blocks/block.py#L85

Eg. https://github.com/realtimeradio/vla-dev/blob/d8afc10119d10ec0e4ef5374493814f11f6585b9/software/control_sw/src/blocks/input.py#L167

talonmyburgh commented 2 years ago

Closed with this commit: b53d8de23df056f132c0f5ed21aa52e6bc690051 ?