realworld-angular / realworld-angular-starter

RealWorld Angular template
https://demo.realworldangular.org/
Apache License 2.0
21 stars 4 forks source link

feat(stylelint): add stylelint on push/pull request #19

Closed ZvSimon closed 3 months ago

ZvSimon commented 3 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Nothing.

What is the new behavior?

Add Stylelint to make styling more maintainable.

Explanation of the Stylelint Rules

1. no-empty-source: null

This rule normally disallows empty sources, meaning files that don't contain any CSS code. Setting this rule to null disables the check, allowing empty CSS files without raising an error.

2. at-rule-no-unknown: null

This rule prevents the use of unknown at-rules (e.g., @unknown-rule). By setting this rule to null, the linter will not check for unknown at-rules, which can be useful if you're using custom at-rules or non-standard syntax.

3. no-duplicate-selectors: null

This rule disallows duplicate selectors within a stylesheet. With the rule set to null, the linter will not flag cases where the same selector is used more than once in a file, which might be intentional in some coding scenarios.

Does this PR introduce a breaking change?

Other information

netlify[bot] commented 3 months ago

Deploy Preview for storybook-realworld-angular ready!

Name Link
Latest commit 17cf9ec2c75e4e22bb6097d1a1892e3f4cdb344b
Latest deploy log https://app.netlify.com/sites/storybook-realworld-angular/deploys/66ba7bc962cc9b0008e54cae
Deploy Preview https://deploy-preview-19--storybook-realworld-angular.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for realworld-angular-starter ready!

Name Link
Latest commit 17cf9ec2c75e4e22bb6097d1a1892e3f4cdb344b
Latest deploy log https://app.netlify.com/sites/realworld-angular-starter/deploys/66ba7bc99837ad0008954560
Deploy Preview https://deploy-preview-19--realworld-angular-starter.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

geromegrignon commented 3 months ago

Thanks for the contribution.