search

realworldocaml / mdx

Execute code blocks inside your documentation
ISC License
269 stars 45 forks source link

Remove `require-package` label support #363

Closed Leonidas-from-XIV closed 2 years ago

Leonidas-from-XIV commented 2 years ago

This tests functionality that we don't support anymore since the way to do this is via the dune stanza.

NathanReb commented 2 years ago

Probably worth removing the label as well as part of this PR! It should probably have a mention in the changelog, maybe simply a ref to this PR in the remove ocaml-mdx rule entry would suffice. What do you think?

Leonidas-from-XIV commented 2 years ago

I've removed the label and added a changelog entry. I think it won't hurt to be specific about this in the changelog in case people wonder what happened to this label.

NathanReb commented 2 years ago

To clarify this label was only consumed by ocaml-mdx rule. The only affected users would be the ones who use this label without using ocaml-mdx rule and they should probably be notified! I think it's alright to remove it from MDX in 2.0.0 without an explicit deprecation as it was directly tied to the rule subcommand which we did deprecate!