search

realworldocaml / mdx

Execute code blocks inside your documentation
ISC License
268 stars 45 forks source link

Revert "Rewrite redirect code with pipe and cloexec" #403 #414

Closed MisterDA closed 1 year ago

MisterDA commented 1 year ago

This reverts commit https://github.com/realworldocaml/mdx/commit/de43f19ab1f3e37acc439fb27a54fb7ea978935d, introduced in "Rewrite redirect code with pipe and cloexec" #403.

It is not possible (or difficult) to set non-blocking mode on pipes on Windows. Moreover, using pipes instead of a file as a buffer between subprocesses makes it harder to investigate hangs and data being transferred.

I've added explicit close-on-exec flags from the previous PR.

Leonidas-from-XIV commented 1 year ago

@MisterDA @polytypic Thanks for the input. I'll try to wrestle the CI to get it to build.