search

reanahub / reana-auth-vomsproxy

REANA VOMS proxy authenticator
http://www.reana.io
MIT License
0 stars 23 forks source link

ci: initial configuration #6

Closed tiborsimko closed 2 years ago

tiborsimko commented 4 years ago

Introduce Travis CI.

It is dangerous to push images to Docker Hub after each commit if the image is not tested.

The CI should:

alintulu commented 4 years ago

You could maybe also do it with Github actions? That would save the need to build the image twice, once for Travis testing and once with actions for deploying it.

With actions you could define three jobs

  1. Build the image
  2. Test the image
  3. Push the image to registry

Step 3 would only be triggered on success of Step 1 and Step 2.

tiborsimko commented 4 years ago

Yes, using GitHub Actions will also nicely do. (BTW Docker Hub could also trigger builds, and GitHub could also hold image repositories, but let's not explore going that way yet...)

clelange commented 4 years ago

GitHub has quite some restrictions on image size, so I don't think keeping the image here rather than on Docker Hub is a viable option at the moment.

I'm a bit afraid that all what you're trying to achieve here is possible and already done on CERN GitLab, and we're wasting our time implementing the same thing on GitHub again with unknown potential complications. If further tests are required, I would rather have this repository be a mirror of what is on GitLab or the other way round, but have the full CI on CERN GitLab and also push to Docker Hub from there.

tiborsimko commented 2 years ago

Closing this old issue; the first CI functionality was implemented in #4 and later made to behave similarly as the other REANA components in #14.