search

reanahub / reana-client

REANA command-line client
http://reana-client.readthedocs.io/
MIT License
10 stars 46 forks source link

cli: secrets-add full path upload #305

Closed tiborsimko closed 5 years ago

tiborsimko commented 5 years ago

When uploading secrets from file, the full path does not seem to be accepted.

This works OK:

$ reana-client secrets-add --from-file .keytab

This does not:

$ reana-client secrets-add --from-file ~/.keytab

Even though we advertise it like this in the docs :wink:

We should fix the path resolution.

tiborsimko commented 5 years ago

BTW note also that in the second case the message to the user looks like everything went well:

$ reana-client secrets-add --from-file ~/.keytab
Secrets /home/johndoe/.keytab were successfully uploaded.

event though the file was not added:

$ reana-client secrets-list
NAME   TYPE

We should also catch situations of this kind, e.g. if there is nothing to upload, then the initial message to the user should be different and not "successfully uploaded".