search

reanahub / reana-client

REANA command-line client
http://reana-client.readthedocs.io/
MIT License
10 stars 46 forks source link

cli: outdated reana-commons API ref. #417

Closed Sinclert closed 4 years ago

Sinclert commented 4 years ago

When testing the installation of a local REANA cluster using the latest documentation, and the current development version of all repositories (v0.7.0-dev...) I ran into an issue.

The problem

When executing:

eval $(reana-dev setup-environment)
reana-client ping

An error is shown describing that the SERVER IS INVALID.

The solution

I think it is due to this reana-commons refactor, where the endpoint /get_me was replaced by /get_you. This endpoint seems to be used internally by reana_client.api.client.py when performing the ping operation (more precisely, in this line).

The test

I have uninstalled reana-client from my local environment and installed a locally modified version with the patch, set up the environment variables again, and the ping command worked as expected.

mvidalgarcia commented 4 years ago

@Sinclert Thanks for the report! 👍 You're totally right! As you have the patch already, could you create a PR? Otherwise we can do it, no problem, let us know.

Sinclert commented 4 years ago

I can propose a PR right away, bumping the version too.