search

reanahub / reana-client

REANA command-line client
http://reana-client.readthedocs.io/
MIT License
10 stars 45 forks source link

snakemake: add environment validation function #542

Closed MMFernando closed 2 years ago

MMFernando commented 2 years ago

closes #540

codecov-commenter commented 2 years ago

Codecov Report

Merging #542 (e02188f) into master (4e2101d) will decrease coverage by 0.36%. The diff coverage is 21.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   59.36%   58.99%   -0.37%     
==========================================
  Files          20       20              
  Lines        2318     2341      +23     
==========================================
+ Hits         1376     1381       +5     
- Misses        942      960      +18
Impacted Files Coverage Δ
reana_client/validation/environments.py 26.44% <21.73%> (-0.59%) :arrow_down:
mvidalgarcia commented 2 years ago

Could you please remove this check as well in a separate commit?

The whole exception handling shouldn't be needed as we don't support py27 anymore.

mvidalgarcia commented 2 years ago

Superseded by https://github.com/reanahub/reana-client/pull/547