search

reanahub / reana-client

REANA command-line client
http://reana-client.readthedocs.io/
MIT License
10 stars 46 forks source link

snakemake: add environment validation #547

Closed mvidalgarcia closed 3 years ago

mvidalgarcia commented 3 years ago

closes #540

Supersedes https://github.com/reanahub/reana-client/pull/542

To test

$ cd ../reana-demo-root6-roofit   # test also helloworld & worldpopulation
$ reana-client validate --environments -f reana-snakemake.yaml --pull
==> Verifying REANA specification file... /Users/marco/code/reanahub/reana-demo-root6-roofit/reana-snakemake.yaml
  -> SUCCESS: Valid REANA specification file.
==> Verifying REANA specification parameters... 
  -> SUCCESS: REANA specification parameters appear valid.
==> Verifying workflow parameters and commands... 
  -> SUCCESS: Workflow parameters and commands appear valid.
==> Verifying dangerous workflow operations... 
  -> SUCCESS: Workflow operations appear valid.
==> Verifying environments in REANA specification file...
  -> SUCCESS: Environment image reanahub/reana-env-root6:6.18.04 has the correct format.
  -> SUCCESS: Environment image reanahub/reana-env-root6:6.18.04 exists locally.
  -> SUCCESS: Environment image reanahub/reana-env-root6:6.18.04 exists in Docker Hub.
  -> INFO: Environment image uses UID 0 but will run as UID 1000.
mvidalgarcia commented 3 years ago

Shall we release r-commons and bump its minimal version here before merging?

Yes, r-commons already released, upgrading and merging this PR...

codecov-commenter commented 3 years ago

Codecov Report

Merging #547 (ccbc795) into master (4e2101d) will decrease coverage by 0.00%. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   59.36%   59.35%   -0.01%     
==========================================
  Files          20       20              
  Lines        2318     2320       +2     
==========================================
+ Hits         1376     1377       +1     
- Misses        942      943       +1
Impacted Files Coverage Δ
reana_client/validation/environments.py 27.36% <18.18%> (+0.34%) :arrow_up:
reana_client/api/client.py 45.00% <100.00%> (+0.09%) :arrow_up: