search

reanahub / reana-client

REANA command-line client
http://reana-client.readthedocs.io/
MIT License
10 stars 46 forks source link

create: --skip-validation doesn't skip #565

Closed tiborsimko closed 3 years ago

tiborsimko commented 3 years ago

Current behaviour

$ reana-client create --skip-validation -w skip    
==> Verifying REANA specification file... reana-demo-atlas-recast/reana.yaml
  -> SUCCESS: Valid REANA specification file.
==> Verifying REANA specification parameters... 
  -> SUCCESS: REANA specification parameters appear valid.
==> Verifying workflow parameters and commands... 
  -> WARNING: Yadage parameter "nomsig" found on step "statanalysis" is not defined in input parameters.
  -> WARNING: Yadage parameter "limit" found on step "statanalysis" is not defined in input parameters.
  -> WARNING: Yadage parameter "pre" found on step "statanalysis" is not defined in input parameters.
  -> WARNING: Yadage parameter "post" found on step "statanalysis" is not defined in input parameters.
  -> WARNING: Yadage parameter "histfile" found on step "eventselection" is not defined in input parameters.
==> Verifying dangerous workflow operations... 
  -> SUCCESS: Workflow operations appear valid.
skip.1

Expected behaviour

Validation instructions shouldntt be run (and shouldn't be displayed) when --skip-validation is passed.