mvidalgarcia commented 2 years ago

Introduces new --workspaces flag to perform workspaces validation. Only requires access token when this flag is passed, in order to perform the REST API checks against reana-server.

Closes #568

codecov-commenter commented 2 years ago

Codecov Report

Merging #569 (bd61b22) into master (3624b59) will increase coverage by 0.95%. The diff coverage is 100.00%.

:exclamation: Current head bd61b22 differs from pull request most recent head 896eab6. Consider uploading reports for the commit 896eab6 to get more accurate results

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   58.19%   59.14%   +0.95%     
==========================================
  Files          20       20              
  Lines        2399     2411      +12     
==========================================
+ Hits         1396     1426      +30     
+ Misses       1003      985      -18

Impacted Files	Coverage Δ
reana_client/cli/utils.py	`71.26% <100.00%> (+0.50%)`	:arrow_up:
reana_client/cli/workflow.py	`63.65% <100.00%> (+0.68%)`	:arrow_up:
reana_client/utils.py	`74.74% <100.00%> (+6.70%)`	:arrow_up:
reana_client/api/client.py	`45.01% <0.00%> (+1.02%)`	:arrow_up:

mvidalgarcia commented 2 years ago

suggestion: this is an error message coming from validate_workspaces:
==> Verifying workspace in REANA specification file...
==> ERROR: ==> ERROR: Desired workspace "/var/reanagrgrgr" not valid.
We can update REANAValidationError message in this function and remove "==> ERROR" part.

Have you installed the reana-commons PR locally? This should be fixed here.

mvidalgarcia commented 2 years ago

Superseded by https://github.com/reanahub/reana-client/pull/570

reanahub / reana-client

validate: require `access_token` only for workspaces #569

Codecov Report